oneby-wang commented on PR #25091: URL: https://github.com/apache/pulsar/pull/25091#issuecomment-3684719795
Since uncommitted or aborted messages will not be delivered to consumer, counting them into `numMessages` or`markerMessages` seems all improper. The aborted messages is filtered by `AbstractBaseDispatcher`. https://github.com/apache/pulsar/blob/449552534c1e1191056e957bc31081760560ff9a/pulsar-broker/src/main/java/org/apache/pulsar/broker/service/AbstractBaseDispatcher.java#L199-L206 The uncommitted messages will not be read and delivered before committed. https://github.com/apache/pulsar/blob/449552534c1e1191056e957bc31081760560ff9a/pulsar-broker/src/main/java/org/apache/pulsar/broker/service/persistent/PersistentTopic.java#L4789-L4791 Maybe we should modify `OpScan` scan params and scan logic and filter aborted messages in `analyzeBacklog` method, so the backlog would be consistent with consumer backlog. https://github.com/apache/pulsar/blob/449552534c1e1191056e957bc31081760560ff9a/managed-ledger/src/main/java/org/apache/bookkeeper/mledger/impl/OpScan.java#L129-L132 @lhotari WDYT? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
