poorbarcode commented on code in PR #25048:
URL: https://github.com/apache/pulsar/pull/25048#discussion_r2660130205
##########
pulsar-broker/src/main/java/org/apache/pulsar/broker/service/ServerCnx.java:
##########
@@ -1730,12 +1730,8 @@ protected void handleProducer(final CommandProducer
cmdProducer) {
BrokerServiceException.getClientErrorCode(exception),
message);
}
- var cause =
FutureUtil.unwrapCompletionException(exception);
- if (!(cause instanceof IncompatibleSchemaException)) {
- log.error("Try add schema failed, remote address
{}, topic {}, producerId {}",
- remoteAddress,
- topicName, producerId, exception);
- }
+ log.warn("Try add schema failed, remote address {},
topic {}, producerId {}",
Review Comment:
```java
if (!(cause instanceof IncompatibleSchemaException)) {
log.error("Try add schema failed, remote address {}, topic {},
producerId {}",
remoteAddress,
topicName, producerId, exception);
log.warn("Try add schema failed, remote address {}, topic {},
producerId {}",
remoteAddress, topicName, producerId, exception);
}
```
The variable `cause` may be an error that unexpected, such as failed to
write BK/ZK, could we modify the log level for the certain error that we knew
only
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
