lhotari commented on code in PR #645:
URL: https://github.com/apache/pulsar-helm-chart/pull/645#discussion_r2661397827
##########
charts/pulsar/templates/bookkeeper-configmap.yaml:
##########
@@ -55,6 +55,12 @@ data:
{{- else }}
ledgerDirectories: "/pulsar/data/bookkeeper/ledgers"
{{- end }}
+ {{- $indexDirs := include "pulsar.bookkeeper.indexDirectories" . }}
+ {{- if $indexDirs }}
+ # Configure RocksDB/index location for DbLedgerStorage. When unset,
BookKeeper falls back to ledgerDirectories.
+ indexDirectories: {{ $indexDirs | quote }}
+ PULSAR_PREFIX_indexDirectories: {{ $indexDirs | quote }}
Review Comment:
It seems that `PULSAR_PREFIX_indexDirectories` is unnecessary.
The `apply-config-from-env.py` script takes commented out lines into
account. Tested this in apache/pulsar working dir:
```shell
indexDirectories=foo docker/pulsar/scripts/apply-config-from-env.py
conf/bookkeeper.conf
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
