BewareMyPower commented on PR #25117: URL: https://github.com/apache/pulsar/pull/25117#issuecomment-3723572398
> once the previous ledger is trimmed, cursor's markDeletePosition is inconsistent with ledger data. Could there be any real issue caused by this inconsistency? It would be helpful if you can share a test to show the impacts. For example, generally computing `(x, y+1)` as the next position of `(x, y)` works in most cases even if there is no entry located in `(x, y+1)` because the `compareTo` implementation guarantees `(x, y) < (x, y+1) < (x+1, 0)`. I think it's a bit different from #25087. From what I understand, #25087 mainly fixes the bug that `onCursorMarkDeletePositionUpdated` is called directly without calling `asyncMarkDelete`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
