zooo-code commented on issue #25128:
URL: https://github.com/apache/pulsar/issues/25128#issuecomment-3743379473
Hi @lhotari ! @oneby-wang I'd like to work on this issue if it's available.
I've reviewed the code and noticed a discrepancy between the two methods:
- getNamespacePolicies() (sync, deprecated):
Uses NamespaceBundleFactory.getBundles().getBundlesData() with a fallback
- getNamespacePoliciesAsync():
Uses LocalPolicies.bundles without the fallback logic
Before proposing a fix, I have a question:
Which source is the correct one for bundle data?
- Should we use NamespaceBundleFactory (as the sync method does)?
Or is LocalPolicies the intended source (as the async method currently
does)?
I noticed that getBundlesAsync() exists in NamespaceBundleFactory
(used in NamespacesBase.java:364), so we could potentially apply the same
logic to the async method.
Also, regarding the recent PR #24762 that fixed bundle-related issues —
should this change align with that approach?
Could you provide some guidance on the intended behavior? Once clarified,
I'm happy to submit a PR with tests.
Thanks!!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
