lhotari commented on code in PR #25156: URL: https://github.com/apache/pulsar/pull/25156#discussion_r2703667625
########## pulsar-testclient/src/test/java/org/apache/pulsar/testclient/LoadSimulationControllerTest.java: ########## @@ -0,0 +1,69 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package org.apache.pulsar.testclient; + +import java.lang.reflect.Field; +import java.util.Map; +import java.util.concurrent.ExecutorService; +import org.junit.jupiter.api.Test; + +import static org.junit.jupiter.api.Assertions.assertTrue; Review Comment: In Pulsar, we use TestNG instead of Junit 5. Please use TestNG imports instead. ########## pulsar-testclient/src/test/java/org/apache/pulsar/testclient/LoadSimulationControllerTest.java: ########## @@ -0,0 +1,69 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package org.apache.pulsar.testclient; + +import java.lang.reflect.Field; +import java.util.Map; +import java.util.concurrent.ExecutorService; +import org.junit.jupiter.api.Test; + +import static org.junit.jupiter.api.Assertions.assertTrue; Review Comment: Please ensure that CI passes in "Personal CI". The instructions for setting this up are at https://pulsar.apache.org/contribute/personal-ci/. ########## pulsar-testclient/src/main/java/org/apache/pulsar/testclient/LoadSimulationController.java: ########## @@ -20,6 +20,7 @@ import static org.apache.pulsar.broker.resources.LoadBalanceResources.BUNDLE_DATA_BASE_PATH; import static org.apache.pulsar.broker.resources.LoadBalanceResources.RESOURCE_QUOTA_BASE_PATH; + Review Comment: The Pulsar code style doesn't contain an empty line between static imports. Please see https://pulsar.apache.org/contribute/setup-ide/#configure-code-style how to setup IntelliJ code style if you happen to use IntelliJ. You can quickly run checkstyle from the command line with this command: ```shell mvn initialize checkstyle:check ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
