zooo-code commented on code in PR #25158:
URL: https://github.com/apache/pulsar/pull/25158#discussion_r2704268253
##########
pulsar-broker/src/test/java/org/apache/pulsar/broker/admin/AdminApiTest.java:
##########
@@ -3429,6 +3429,36 @@ public void testCreateAndDeleteNamespaceWithBundles()
throws Exception {
deleteNamespaceWithRetry(ns, false);
}
+ @Test
+ public void testGetNamespacePoliciesSyncAsyncBundlesConsistency() throws
Exception {
Review Comment:
@lhotari Thanks for the feedback!
You're right—the current test would likely pass even before the change
because LocalPolicies.bundles and NamespaceBundleFactory.getBundles() often
return the same value in normal scenarios.
To address this, I'll update the test to explicitly verify that the bundles
are retrieved via NamespaceBundleFactory. Would mocking NamespaceBundleFactory
and verifying the call to getBundlesAsync() be the preferred approach here?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
