lhotari commented on PR #25167:
URL: https://github.com/apache/pulsar/pull/25167#issuecomment-3772989104

   > > No, that commit is already included in my local branch
   > 
   > #25155 solution gets only activated for IntelliJ at the moment.
   > 
   > I guess it would be somewhat different for Eclipse based solutions.
   > 
   > something like this to be added in 
`jetty-upgrade/zookeeper-with-patched-admin/pom.xml`
   > 
   > ```
   >     <profile>
   >       <id>eclipse</id>
   >       <build>
   >         <pluginManagement>
   >           <plugins>
   >             <plugin>
   >               <groupId>org.eclipse.m2e</groupId>
   >               <artifactId>lifecycle-mapping</artifactId>
   >               <version>1.0.0</version>
   >               <configuration>
   >                 <lifecycleMappingMetadata>
   >                   <pluginExecutions>
   >                     <pluginExecution>
   >                       <pluginExecutionFilter>
   >                         <groupId>org.codehaus.mojo</groupId>
   >                         <artifactId>build-helper-maven-plugin</artifactId>
   >                         <versionRange>[3.0.0,)</versionRange>
   >                         <goals>
   >                           <goal>attach-artifact</goal>
   >                         </goals>
   >                         <configuration>
   >                           <artifacts>
   >                             <artifact>
   >                               
<file>${project.build.directory}/${project.build.finalName}.jar</file>
   >                               <type>jar</type>
   >                               <classifier>shaded</classifier>
   >                             </artifact>
   >                           </artifacts>
   >                         </configuration>
   >                       </pluginExecutionFilter>
   >                     </pluginExecution>
   >                     <action>
   >                       <ignore />
   >                     </action>
   >                   </pluginExecutions>
   >                 </lifecycleMappingMetadata>
   >               </configuration>
   >             </plugin>
   >           </plugins>
   >         </pluginManagement>
   >       </build>
   >     </profile>
   > ```
   > 
   > I haven't validated this solution yet. I'll check with VSCode.
   
   I could get this solution to work in VSCode. I also tried multiple different 
revisions.
   The profile can be activated with 
   ```
         <activation>
           <property>
             <name>m2e.version</name>
           </property>
         </activation>
   ```
   but I couldn't get the classpath to include the shaded results.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to