lhotari commented on code in PR #25179:
URL: https://github.com/apache/pulsar/pull/25179#discussion_r2719874084
##########
pulsar-proxy/src/main/java/org/apache/pulsar/proxy/server/ProxyConnection.java:
##########
@@ -436,6 +433,10 @@ private void handleBrokerConnected(DirectProxyHandler
directProxyHandler, Comman
final ByteBuf msg =
Commands.newConnected(connected.getProtocolVersion(), maxMessageSize,
connected.hasFeatureFlags() &&
connected.getFeatureFlags().isSupportsTopicWatchers());
writeAndFlush(msg);
+ // Start auth refresh task only if we are not forwarding
authorization credentials
+ if
(!service.getConfiguration().isForwardAuthorizationCredentials()) {
+ startAuthRefreshTaskIfNotStarted();
+ }
Review Comment:
I might take this back. It seems that this change makes sense. now noticed
`if (!authState.isExpired()) {` and if the authorization credentials aren't
forwarded, this makes sense. resolving this comment.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
