sandeep-mst opened a new pull request, #25207:
URL: https://github.com/apache/pulsar/pull/25207
<!-- Either this PR fixes an issue, -->
Fixes #25201
### Motivation
<!-- Explain here the context, and why you're making that change. What is
the problem you're trying to solve. -->
Fix a re-entrancy bug in `ProducerImpl.failPendingMessages`. While executing
on the timer, `failPendingMessages` invokes `sendComplete(ex)` on pending
messages, which can synchronously trigger a retry from client code. The
subsequent `pendingMessages.clear()` then removes the newly enqueued retry
operation, leaving the retry’s CompletableFuture unresolved and the client in a
limbo state.
### Modifications
<!-- Describe the modifications you've done. -->
Updated `failPendingMessages` to first drain the `pendingMessages` queue
into a local list and clear the queue before iterating. This prevents
re-entrant retries triggered during sendComplete from being inadvertently
cleared.
### Verifying this change
- [x] Make sure that the change passes the CI checks.
This change added tests and can be verified as follows:
-
*org.apache.pulsar.client.impl.ProducerImplTest#testFailPendingMessagesSyncRetry*
### Does this pull request potentially affect one of the following parts:
<!-- DO NOT REMOVE THIS SECTION. CHECK THE PROPER BOX ONLY. -->
*If the box was checked, please highlight the changes*
- [ ] Dependencies (add or upgrade a dependency)
- [ ] The public API
- [ ] The schema
- [ ] The default values of configurations
- [ ] The threading model
- [ ] The binary protocol
- [ ] The REST endpoints
- [ ] The admin CLI options
- [ ] The metrics
- [ ] Anything that affects deployment
### Documentation
<!-- DO NOT REMOVE THIS SECTION. CHECK THE PROPER BOX ONLY. -->
- [ ] `doc` <!-- Your PR contains doc changes. -->
- [ ] `doc-required` <!-- Your PR changes impact docs and you will update
later -->
- [x] `doc-not-needed` <!-- Your PR changes do not impact docs -->
- [ ] `doc-complete` <!-- Docs have been already added -->
### Matching PR in forked repository
PR in forked repository: <!-- ENTER URL HERE -->
https://github.com/cognitree/pulsar/pull/29
<!--
After opening this PR, the build in apache/pulsar will fail and instructions
will
be provided for opening a PR in the PR author's forked repository.
apache/pulsar pull requests should be first tested in your own fork since
the
apache/pulsar CI based on GitHub Actions has constrained resources and quota.
GitHub Actions provides separate quota for pull requests that are executed
in
a forked repository.
The tests will be run in the forked repository until all PR review comments
have
been handled, the tests pass and the PR is approved by a reviewer.
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
