lhotari commented on PR #25207: URL: https://github.com/apache/pulsar/pull/25207#issuecomment-3846373987
> > LGTM, great work @sandeep-mst . Just a wish to add a test mentioned in the description. > > Will add it if possible. That test will go to `pulsar-broker` module. Should I remove the currently added test afterwards? I think the current unit tests are fine. The additional test would be a bit like an integration test. In Pulsar, the tests which use the `MockedPulsarServiceBaseTest` base class are in most cases integration tests although we call them "unit tests" in CI. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
