BewareMyPower commented on PR #25208: URL: https://github.com/apache/pulsar/pull/25208#issuecomment-3846672067
Glad to see yet another recycler based class is removed. It's typically a case that recyclable should not be used (concurrent access). Actually, we should synchronize `isDuplicate` and `flushAsync`. I drafted a similar PR half year ago (but just forgot to proceed): https://github.com/BewareMyPower/pulsar/pull/52/changes IMO the `ConcurrentBitSet` is also over designed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
