lhotari commented on code in PR #24809: URL: https://github.com/apache/pulsar/pull/24809#discussion_r2773461407
########## pulsar-client/src/main/java/org/apache/pulsar/client/impl/TableViewBuilderImpl.java: ########## @@ -22,14 +22,10 @@ import java.util.Map; import java.util.concurrent.CompletableFuture; import java.util.concurrent.TimeUnit; +import java.util.function.Function; import lombok.NonNull; import org.apache.commons.lang3.StringUtils; -import org.apache.pulsar.client.api.ConsumerCryptoFailureAction; -import org.apache.pulsar.client.api.CryptoKeyReader; -import org.apache.pulsar.client.api.PulsarClientException; -import org.apache.pulsar.client.api.Schema; -import org.apache.pulsar.client.api.TableView; Review Comment: don't remove this import so that the code doesn't have to reference the full class name. ########## pulsar-client/src/test/java/org/apache/pulsar/client/impl/TableViewImplTest.java: ########## @@ -24,7 +24,6 @@ import static org.testng.Assert.assertNotNull; import org.apache.pulsar.client.api.CryptoKeyReader; import org.apache.pulsar.client.api.Schema; -import org.apache.pulsar.client.api.TableView; Review Comment: don't remove this import so that the code doesn't have to reference the full class name. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
