Thorbenl commented on issue #254:
URL:
https://github.com/apache/pulsar-dotpulsar/issues/254#issuecomment-3877271751
@blankensteiner @jklinaku
- Should JsonSchema<T> accept a schema definition string? The Pulsar broker
uses schema data for compatibility checking. Our default constructor sends empty
data, which means the broker won't validate schema evolution. This is
fine for a first implementation (matches how primitive schemas work) but worth
noting
in the PR description.
- ProtobufNative vs Protobuf: We chose ProtobufNative (type 20) which uses
the native protobuf descriptor. The alternative is Protobuf (type 3) which uses
Avro-encoded schema. ProtobufNative is the more modern approach and
matches what the Java client's Schema.PROTOBUF does internally. Worth calling
out in the
PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
