merlimat commented on code in PR #25237:
URL: https://github.com/apache/pulsar/pull/25237#discussion_r2790749876
##########
pulsar-metadata/src/main/java/org/apache/pulsar/metadata/impl/PulsarZooKeeperClient.java:
##########
@@ -151,6 +159,15 @@ public String toString() {
};
+ private ZooKeeper getZkHandle() {
+ lock.readLock().lock();
Review Comment:
I don't see how this read lock is helping here. By the time we get the
object and we release the lock it can be closed and reset. I would be the same
as the `zk.get()`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
