Copilot commented on code in PR #457:
URL:
https://github.com/apache/pulsar-client-node/pull/457#discussion_r2792229533
##########
src/Client.js:
##########
@@ -49,7 +49,7 @@ class Client {
}
close() {
- this.client.close();
+ return this.client.close();
}
Review Comment:
Consider adding a Jest test that asserts `client.close()` returns a Promise
(and can be awaited). The existing tests `await client.close()` would still
pass when `close()` returned `undefined`, so they wouldn't catch a regression
of this bug fix.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
