lhotari commented on code in PR #25252:
URL: https://github.com/apache/pulsar/pull/25252#discussion_r2832070756
##########
pulsar-client-shaded/pom.xml:
##########
@@ -157,7 +157,7 @@
<include>jakarta.ws.rs:jakarta.ws.rs-api</include>
<include>jakarta.xml.bind:jakarta.xml.bind-api</include>
<include>javax.ws.rs:*</include>
- <include>net.jcip:jcip-annotations</include>
+ <include>com.github.spotbugs:spotbugs-annotations</include>
Review Comment:
```suggestion
<include>com.google.code.findbugs:jsr305</include>
```
##########
pom.xml:
##########
@@ -1516,13 +1515,12 @@ flexible messaging model and an intuitive client
API.</description>
<artifactId>javassist</artifactId>
<version>${javassist.version}</version>
</dependency>
-
<dependency>
- <groupId>net.jcip</groupId>
- <artifactId>jcip-annotations</artifactId>
- <version>${jcip.version}</version>
+ <groupId>com.google.code.findbugs</groupId>
+ <artifactId>jsr305</artifactId>
+ <version>3.0.2</version>
+ <scope>compile</scope>
Review Comment:
please add a property `jsr305.version` and reference it here. The `scope`
could be omitted in dependency management dependencies.
##########
pulsar-client-all/pom.xml:
##########
@@ -189,7 +189,7 @@
<include>jakarta.xml.bind:jakarta.xml.bind-api</include>
<include>javax.ws.rs:*</include>
<include>javax.xml.bind:jaxb-api</include>
- <include>net.jcip:jcip-annotations</include>
+ <include>com.github.spotbugs:spotbugs-annotations</include>
Review Comment:
```suggestion
<include>com.google.code.findbugs:jsr305</include>
```
##########
pom.xml:
##########
@@ -260,7 +260,6 @@ flexible messaging model and an intuitive client
API.</description>
<hdfs-offload-version3>${hadoop3.version}</hdfs-offload-version3>
<hbase.version>2.6.3-hadoop3</hbase.version>
<guava.version>33.4.8-jre</guava.version>
- <jcip.version>1.0</jcip.version>
Review Comment:
replace with `<jsr305.version>3.0.2</jsr305.version>`
##########
pulsar-client-admin-shaded/pom.xml:
##########
@@ -141,7 +141,7 @@
<include>jakarta.xml.bind:jakarta.xml.bind-api</include>
<include>javax.ws.rs:*</include>
<include>javax.xml.bind:jaxb-api</include>
- <include>net.jcip:jcip-annotations</include>
+ <include>com.github.spotbugs:spotbugs-annotations</include>
Review Comment:
```suggestion
<include>com.google.code.findbugs:jsr305</include>
```
##########
pulsar-client/pom.xml:
##########
@@ -180,10 +180,7 @@
<artifactId>jackson-module-jsonSchema</artifactId>
</dependency>
- <dependency>
- <groupId>net.jcip</groupId>
- <artifactId>jcip-annotations</artifactId>
- </dependency>
Review Comment:
replace with
```xml
<dependency>
<groupId>com.google.code.findbugs</groupId>
<artifactId>jsr305</artifactId>
</dependency>
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
