BewareMyPower commented on code in PR #543:
URL: https://github.com/apache/pulsar-client-cpp/pull/543#discussion_r2881508905
##########
LegacyFindPackages.cmake:
##########
@@ -79,6 +79,10 @@ if (APPLE)
set(OPENSSL_ROOT_DIR ${OPENSSL_ROOT_DIR} /usr/local/opt/openssl/
/opt/homebrew/opt/openssl)
endif ()
find_package(OpenSSL REQUIRED)
+# Ensure OPENSSL_LIBRARIES is a proper CMake list (ssl and crypto as separate
entries)
Review Comment:
That's right. Though it's more recommended to enable `INTEGRATE_VCPKG` if
you're building the library yourself. Currently, this option is stilled
reserved only for the Windows build workflow, which installs dependencies via
`vcpkg install` first, then find dependencies in legacy mode.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
