crossoverJie commented on PR #1468: URL: https://github.com/apache/pulsar-client-go/pull/1468#issuecomment-3995704008
Code review finding (High): in `pulsar/internal/service_uri.go::fromString`, the new multi-host split logic uses `strings.IndexFunc(uriStr, splitURI)` on the full URI string. This can misinterpret commas/semicolons in path/query as host delimiters (e.g. `pulsar://host1:6650/path,segment`), silently adding bogus hosts and changing behavior. Suggestion: parse with `url.Parse` first, then split only the authority/host portion for multi-host handling. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
