BewareMyPower commented on code in PR #546:
URL: https://github.com/apache/pulsar-client-cpp/pull/546#discussion_r2890336091
##########
tests/ReaderTest.cc:
##########
@@ -863,7 +864,13 @@ TEST_P(ReaderSeekTest,
testHasMessageAvailableAfterSeekToEnd) {
}
ASSERT_EQ(ResultOk, reader.seek(MessageId::latest()));
- ASSERT_EQ(ResultOk, reader.hasMessageAvailable(hasMessageAvailable));
+ // After seek-to-end the broker may close the consumer and trigger
reconnect; allow a short
+ // delay for hasMessageAvailable to become false (avoids flakiness when
reconnect completes).
Review Comment:
It's okay to reduce flakiness to avoid blocking PRs, but it should be noted
that these changes don't fix the bug of `hasMessageAvailable`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
