codelipenghui commented on code in PR #25240:
URL: https://github.com/apache/pulsar/pull/25240#discussion_r2891745240
##########
managed-ledger/src/main/java/org/apache/bookkeeper/mledger/impl/ManagedLedgerImpl.java:
##########
@@ -4418,11 +4447,17 @@ private void checkManagedLedgerIsOpen() throws
ManagedLedgerException {
public synchronized void setFenced() {
log.info("{} Moving to Fenced state", name);
STATE_UPDATER.set(this, State.Fenced);
+ executor.execute(() -> clearNotInitiatedPendingAddEntries(new
ManagedLedgerFencedException("ManagedLedger "
Review Comment:
[Minor] The `executor.execute()` call is not wrapped in try-catch for
`RejectedExecutionException`. During shutdown, the executor may already be
terminated, causing the cleanup to silently fail. Same applies to the other
`executor.execute()` calls in `asyncClose`, `setFencedForDeletion`, and
`operationComplete`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
