hangc0276 commented on code in PR #25171:
URL: https://github.com/apache/pulsar/pull/25171#discussion_r2897693868
##########
pulsar-broker/src/main/java/org/apache/pulsar/broker/service/AbstractBaseDispatcher.java:
##########
@@ -187,7 +187,7 @@ public int filterEntriesForConsumer(@Nullable
MessageMetadata[] metadataArray, i
if (msgMetadata != null && msgMetadata.hasTxnidMostBits()
&& msgMetadata.hasTxnidLeastBits()) {
if (Markers.isTxnMarker(msgMetadata)) {
- if (cursor == null ||
!cursor.getName().equals(Compactor.COMPACTION_SUBSCRIPTION)) {
+ if (!isMarkerAllowedDeliveryToSubscription(cursor)) {
Review Comment:
We can change the isMarkerAllowedDeliveryToSubscription to
isMarkerSkippedDeliveryToSubscription, so we do not need `!` anymore. The
current logic is a little complex.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
