codelipenghui commented on a change in pull request #5123: Modify the schema
decode method can decode ByteBuf
URL: https://github.com/apache/pulsar/pull/5123#discussion_r321190377
##########
File path: pulsar-client-api/pom.xml
##########
@@ -33,11 +33,18 @@
<name>Pulsar Client :: API</name>
<dependencies>
- <dependency>
- <groupId>com.google.protobuf</groupId>
- <artifactId>protobuf-java</artifactId>
- <version>${protobuf3.version}</version>
- <scope>provided</scope>
- </dependency>
+ <dependency>
+ <groupId>com.google.protobuf</groupId>
+ <artifactId>protobuf-java</artifactId>
+ <version>${protobuf3.version}</version>
+ <scope>provided</scope>
+ </dependency>
+
+ <dependency>
+ <groupId>io.netty</groupId>
+ <artifactId>netty-all</artifactId>
Review comment:
I think no need to add netty-all, just netty-buffer
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
