shibd commented on code in PR #551:
URL: https://github.com/apache/pulsar-client-cpp/pull/551#discussion_r2922993930
##########
lib/ClientConnection.h:
##########
@@ -219,28 +218,51 @@ class PULSAR_PUBLIC ClientConnection : public
std::enable_shared_from_this<Clien
mockingRequests_.store(true, std::memory_order_release);
}
- void handleKeepAliveTimeout();
+ void handleKeepAliveTimeout(const ASIO_ERROR& ec);
private:
struct PendingRequestData {
Promise<Result, ResponseData> promise;
DeadlineTimerPtr timer;
std::shared_ptr<std::atomic_bool>
hasGotResponse{std::make_shared<std::atomic_bool>(false)};
+
+ void fail(Result result) {
+ cancelTimer(*timer);
+ ;
Review Comment:
useless line
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
