lhotari commented on code in PR #25293:
URL: https://github.com/apache/pulsar/pull/25293#discussion_r2958636226
##########
pulsar-broker/src/main/java/org/apache/pulsar/broker/service/SystemTopicTxnBufferSnapshotService.java:
##########
@@ -41,13 +41,19 @@ public class SystemTopicTxnBufferSnapshotService<T> {
protected final ConcurrentHashMap<NamespaceName, SystemTopicClient<T>>
clients;
protected final NamespaceEventsSystemTopicFactory
namespaceEventsSystemTopicFactory;
+ protected final PulsarClientImpl pulsarClient;
protected final Class<T> schemaType;
protected final EventType systemTopicType;
private final ConcurrentHashMap<NamespaceName, ReferenceCountedWriter<T>>
refCountedWriterMap;
- @Getter
- private final TableView<T> tableView;
+
+ /** SystemTopicTxnBufferSnapshotService is created only three, see also
+ * {@link TransactionBufferSnapshotServiceFactory}. At the same time,
each object can only
+ * be fixed threads access, see also {@link
PulsarService#transactionSnapshotRecoverExecutorProvider}.
+ * So the un-static ThreadLocal is safe.
+ */
+ private final ThreadLocal<TableView<T>> tableViewThreadLocal = new
ThreadLocal<>();
Review Comment:
How is the TableView instance going to be closed/shutdown if this is the
solution?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
