codelipenghui commented on a change in pull request #4963: Add more config for
auto-topic-creation
URL: https://github.com/apache/pulsar/pull/4963#discussion_r321631161
##########
File path:
pulsar-broker/src/main/java/org/apache/pulsar/broker/admin/AdminResource.java
##########
@@ -519,7 +522,12 @@ protected PartitionedTopicMetadata
getPartitionedTopicMetadata(TopicName topicNa
}
String path = path(PARTITIONED_TOPIC_PATH_ZNODE,
namespaceName.toString(), domain(), topicName.getEncodedLocalName());
- PartitionedTopicMetadata partitionMetadata =
fetchPartitionedTopicMetadata(pulsar(), path);
+ PartitionedTopicMetadata partitionMetadata;
+ if (checkAllowAutoCreation) {
+ partitionMetadata =
fetchPartitionedTopicMetadataCheckAllowAutoCreation(pulsar(), path, topicName);
+ } else {
+ partitionMetadata = fetchPartitionedTopicMetadata(pulsar(), path);
+ }
Review comment:
Is admin api also need to support topic auto creation?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
