merlimat commented on a change in pull request #5155: [pulsar-broker] Close
RateLimiter instance
URL: https://github.com/apache/pulsar/pull/5155#discussion_r322334485
##########
File path:
pulsar-broker/src/main/java/org/apache/pulsar/broker/service/nonpersistent/NonPersistentDispatcherSingleActiveConsumer.java
##########
@@ -146,4 +147,9 @@ protected void readMoreEntries(Consumer consumer) {
protected void cancelPendingRead() {
// No-op
}
+
+ public CompletableFuture<Void> close() {
+ IS_CLOSED_UPDATER.set(this, TRUE);
+ return disconnectAllConsumers();
Review comment:
Since this part is still common, we could keep in the abstract class and
then call `super.close()` where needed
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
