merlimat opened a new pull request, #25685:
URL: https://github.com/apache/pulsar/pull/25685

   ## Summary
   
   Replace the TODO stub on `V5AuthWrapper.authData()` that returned `null` 
with a proper bridge to v4's `AuthenticationDataProvider`. The two interfaces 
(V5 `AuthenticationData` / v4 `AuthenticationDataProvider`) are aligned 
method-for-method, so the new `V5AuthDataWrapper` is a 1:1 delegation across 
HTTP headers, TLS certificates / private keys, and binary-protocol command data.
   
   Without this fix, any V5 caller that asks the wrapped `Authentication` for 
credentials silently gets `null` and either crashes or — worse — sends an 
unauthenticated request.
   
   Also wires the `authData(brokerHostName)` overload, which was previously 
inheriting the default that delegates to `authData()` and would have leaked the 
same `null`.
   
   ## Test plan
   
   - [x] `AuthenticationAdapterTest` (3 unit tests) — token credential 
round-trips through `authData()`; per-host overload delegates; method name 
passes through.
   - [x] `pulsar-client-v5` checkstyle clean.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to