codelipenghui commented on code in PR #25443:
URL: https://github.com/apache/pulsar/pull/25443#discussion_r3192488359


##########
pulsar-broker/src/test/java/org/apache/pulsar/broker/service/OneWayReplicatorUsingGlobalZKTest.java:
##########
@@ -149,6 +149,15 @@ public void testDeleteRemoteTopicByGlobalPolicy() throws 
Exception {
         });
         waitReplicatorStopped(subTopic, pulsar1, pulsar2, true);
 
+        try {
+            admin2.topics().createMissedPartitions(topicName);

Review Comment:
   Consider extracting these assertions into their own `@Test` method.
   
   Only the global-topic-policy branch is exercised — adding cases for the 
local-topic-level and namespace `allowed_clusters` branches plus a positive 
happy-path assertion would catch inverted-boolean regressions.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to