merlimat commented on code in PR #25777:
URL: https://github.com/apache/pulsar/pull/25777#discussion_r3244085775
##########
pulsar-broker/src/main/java/org/apache/pulsar/broker/PulsarService.java:
##########
@@ -755,7 +755,12 @@ public CompletableFuture<Void> closeAsync(boolean
waitForWebServiceToStop) {
log.warn().exception(t).log("Closed with errors");
}
state = State.Closed;
- isClosedCondition.signalAll();
+ mutex.lock();
Review Comment:
I'd actually move the lock one line earlier to include the state change
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
