lhotari commented on code in PR #25773:
URL: https://github.com/apache/pulsar/pull/25773#discussion_r3246722284
##########
pulsar-functions/runtime/src/main/java/org/apache/pulsar/functions/worker/ConnectorsManager.java:
##########
@@ -89,24 +91,34 @@ public Path getSinkArchive(String sinkType) {
}
public void reloadConnectors(WorkerConfig workerConfig) throws IOException
{
- TreeMap<String, Connector> oldConnectors = connectors;
- this.connectors = createConnectors(workerConfig);
- closeConnectors(oldConnectors);
+ boolean enableClassloading =
workerConfig.getEnableClassloadingOfBuiltinFiles()
+ ||
ThreadRuntimeFactory.class.getName().equals(workerConfig.getFunctionRuntimeFactoryClassName());
Review Comment:
This could be extracted into a private method to avoid code duplication
since the same logic is also in createConnectors.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
