RobertIndie commented on code in PR #579:
URL: https://github.com/apache/pulsar-client-cpp/pull/579#discussion_r3301816143
##########
tests/MessageChunkingTest.cc:
##########
@@ -102,7 +104,16 @@ TEST_F(MessageChunkingTest, testInvalidConfig) {
conf.setBatchingEnabled(true);
conf.setChunkingEnabled(true);
Producer producer;
- ASSERT_THROW(client.createProducer("xxx", conf, producer),
std::invalid_argument);
+ ASSERT_EQ(ResultInvalidConfiguration, client.createProducer("xxx", conf,
producer));
Review Comment:
This seems to introduce a breaking change.
Before: throwing the invalid argument exception.
After: returning `ResultInvalidConfiguration`.
Do you think we should avoid this breaking change?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
