merlimat commented on code in PR #25887:
URL: https://github.com/apache/pulsar/pull/25887#discussion_r3337887890
##########
pulsar-testclient/src/main/java/org/apache/pulsar/testclient/PerformanceProducer.java:
##########
@@ -693,11 +702,9 @@ private void runProducer(int producerId,
if (this.isEnableTransaction
&& numMessageSend.incrementAndGet() ==
this.numMessagesPerTransaction) {
if (!this.isAbortTransaction) {
- transaction.commit()
+ transaction.async().commit()
Review Comment:
Good catch — fixed in 70d897584d8. `PerformanceProducer` now collects the
in-flight transaction's send futures and awaits them with `allOf(...).join()`
before `commit()`, mirroring the `PerformanceTransaction` fix you referenced.
The send chain already swallows per-send failures, so the join never throws on
a send error.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
