jiazhai commented on issue #5151: Broker fails to start with function worker enabled and broker client using TLS URL: https://github.com/apache/pulsar/pull/5151#issuecomment-530189510 @cdbartholomew Thanks for the fix. This may work for your test, but may not friendly for user setting. From my view the right logic could like this: 1. `workerConfig.isUseTls` is the main config. If user set `workerConfig.isUseTls=true`, then we should comply with it. 2. once `workerConfig.isUseTls=true`, then it is expect that the broker has already has broker.conf configured with tls enabled and "webServicePortTls" with right value, 3. For the reason analysed in #4560, function worker will create internal admin/client inside worker, it should passively config these: ``` brokerClientTlsEnabled= brokerClientAuthenticationPlugin= brokerClientAuthenticationParameters= ``` As you find above `workerConfig.isUseTls` is the main config that user wanted. and configs in 2 and 3 above, are some passively configs or configs that should comply with user's requirements. @tuteng, who is work on fix for #4560. @jerrypeng, who init this worker config. @murong00, who also touched this part of code recently.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
