Dream95 commented on PR #25916: URL: https://github.com/apache/pulsar/pull/25916#issuecomment-4610349580
> LGTM. Thanks for the fix! > > The missing cleanup for UnAckedTopicMessageRedeliveryTracker looks correct, and the iterator fix in removeTopicMessages is important. > > One non-blocking note: the current getOwnerTopic().contains(topicName) matching seems a bit loose and may match similar topic names, such as my-topic and my-topic-v2. This is pre-existing behavior, so it shouldn’t block this PR. > > Would you be interested in addressing this in a follow-up PR? Thanks for the review. I'll fix that in a follow-up PR. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
