lhotari commented on code in PR #25921:
URL: https://github.com/apache/pulsar/pull/25921#discussion_r3349085299
##########
pulsar-client/src/main/java/org/apache/pulsar/client/impl/UnAckedMessageTracker.java:
##########
@@ -304,4 +306,12 @@ private void stop() {
public void close() {
stop();
}
+
+ protected static boolean messageBelongsToTopic(MessageId messageId, String
topicName) {
Review Comment:
One reason why naming is hard is the fact that the concepts of "owner topic"
and "partitioned topic name" aren't defined properly. For example, the
description `getOwnerTopic` in `TopicMessageId` is "Return the owner topic name
of a message". The concept of "owner topic" isn't described.
The situtation with "partitioned topic name" is better. It's defined as "For
partitions in a topic, return the base partitioned topic name."
Perhaps this gives some ideas for the instance method naming.
For example `boolean hasSameBasePartitionedTopic(String topicName)`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
