lhotari commented on PR #26007: URL: https://github.com/apache/pulsar/pull/26007#issuecomment-4693495934
#26013 fixes the actual root cause which is a regression in Netty. I agree that the test can be improved since there are some flaws. Some of the behavior is intentional such as testing batch messages. One of the main changes in this PR is that it replaces `producer.sendAsync` with `producer.send`. When synchronous send is used, there will be only one message in flight for each producer at a time, which is a different scenario. Batching cannot be tested with `send`. It feels that both cases (`send` and `sendAsync`) should be tested as well as batching. The way how timing is calculated, is way better in this PR. For sendAsync, it could be handled when the future completes. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
