Denovo1998 opened a new pull request, #26109:
URL: https://github.com/apache/pulsar/pull/26109

   ### Motivation
   
   When a replicated subscription update marker is received, the broker 
acknowledges the target subscription position asynchronously. The returned 
future was previously ignored, so failures from the ack path could be dropped 
without any logging or completion observation.
   
   This makes replicated subscription state updates harder to diagnose when the 
local ack fails.
   
   ### Modifications
   
   - Add a helper to acknowledge replicated subscription updates and observe 
the returned future.
   - Log replicated subscription update ack failures with the subscription name 
and position.
   - Use the same helper for both existing subscriptions and subscriptions 
created from incoming replicated updates.
   - Observe subscription creation failures in the create-subscription path.
   - Add a regression test that verifies the update ack future is observed.
   
   ### Verifying this change
   
   - [x] Make sure that the change passes the CI checks.
   
   - gradlew :pulsar-broker:test --tests 
org.apache.pulsar.broker.service.persistent.ReplicatedSubscriptionsControllerTest
 -PtestRetryCount=0`
   
   ### Does this pull request potentially affect one of the following parts:
   
   <!-- DO NOT REMOVE THIS SECTION. CHECK THE PROPER BOX ONLY. -->
   
   *If the box was checked, please highlight the changes*
   
   - [ ] Dependencies (add or upgrade a dependency)
   - [ ] The public API
   - [ ] The schema
   - [ ] The default values of configurations
   - [ ] The threading model
   - [ ] The binary protocol
   - [ ] The REST endpoints
   - [ ] The admin CLI options
   - [ ] The metrics
   - [ ] Anything that affects deployment


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to