lhotari commented on code in PR #26127: URL: https://github.com/apache/pulsar/pull/26127#discussion_r3505699902
########## managed-ledger/src/main/java/org/apache/bookkeeper/mledger/impl/PositionRangeSet.java: ########## Review Comment: Could use a primitive collection provided by `fastutil` here: `Long2ObjectRBTreeMap<LongBitmap> rangeBitmapMap = new Long2ObjectRBTreeMap<>()` (rename `rangeBitSetMap` to `rangeBitmapMap` or `rangeBitmaps`) Also add a comment above the field which explains what the key is and what the value of the map is (explain also the purpose). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
