Shawyeok commented on PR #26128:
URL: https://github.com/apache/pulsar/pull/26128#issuecomment-4875697866
1. intersect no longer trims trailing zero words — breaks the "canonical
ack-set" invariant the old andAckSet upheld
Fixed, now `AckSetUtil#intersect` is aligned with `BitSet#toLongArray` for
trimming the trailing zero word automatically.
2. `isAckSetOverlap` rewrite is trailing-zero-sensitive where the old code
was not
I've restored the change of the method `PositionAckSetUtil#isAckSetOverlap`,
because without the batch size, a trailing zero word is ambiguous —
`BitSetRecyclable.valueOf` trimming means `[-1L, 0L]` ("bits 64–127 acked") is
treated as if those bits don't exist. Maybe we can fix this later in a
dedicated PR.
3. AckSetUtil javadoc / style nits
javadoc fixed, I've removed the Lombok annotation `@UtilityClass`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
