horizonzy opened a new pull request, #26149: URL: https://github.com/apache/pulsar/pull/26149
Motivation `PersistentTopic#checkInactiveSubscriptions` skips built-in system subscriptions such as the compaction subscription when deleting expired inactive subscriptions. However, subscriptions configured through `additionalSystemCursorNames` are also treated as system cursors elsewhere, but were not skipped by this expiration cleanup path. As a result, an additional system cursor could be deleted when it became inactive past the subscription expiration threshold. Modifications • Updated `PersistentTopic#checkInactiveSubscriptions` to skip subscriptions identified by isSystemCursor(subName) instead of only checking the compaction subscription. • Extended `PersistentTopicTest#testCheckInactiveSubscriptions` to configure an additionalSystemCursorNames entry and verify that the corresponding subscription is not deleted during inactive subscription cleanup. ### Does this pull request potentially affect one of the following parts: <!-- DO NOT REMOVE THIS SECTION. CHECK THE PROPER BOX ONLY. --> *If the box was checked, please highlight the changes* - [ ] Dependencies (add or upgrade a dependency) - [ ] The public API - [ ] The schema - [ ] The default values of configurations - [ ] The threading model - [ ] The binary protocol - [ ] The REST endpoints - [ ] The admin CLI options - [ ] The metrics - [ ] Anything that affects deployment -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
