lhotari commented on code in PR #702:
URL: https://github.com/apache/pulsar-helm-chart/pull/702#discussion_r3535589054
##########
charts/pulsar/templates/broker-service.yaml:
##########
@@ -46,7 +46,9 @@ spec:
- name: "{{ .Values.tlsPrefix }}pulsarssl"
port: {{ .Values.broker.ports.pulsarssl }}
{{- end }}
+ {{- if ne .Values.broker.service.clusterIP "" }}
Review Comment:
If a user sets `broker.service.clusterIP: null` in their values (a common
way to "unset" a chart default), Helm drops the key during value coalescing, so
this expression becomes `ne nil ""`, which evaluates to true — rendering
`clusterIP: ""` again and reintroducing the drift this PR fixes. A truthy check
handles both `""` and `null`, while `"None"` and explicit IPs are non-empty
strings and render as before:
```suggestion
{{- if .Values.broker.service.clusterIP }}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
