void-ptr974 commented on PR #26158: URL: https://github.com/apache/pulsar/pull/26158#issuecomment-4904407006
Do we need to change the ZK NOTEMPTY mapping in this PR? The Oxia issue should be fixable by having Oxia throw MetadataStoreException.NotEmptyException and by making markLedgerReplicated() ignore both the new Oxia exception and the existing ZK shape. Changing ZK here also changes the exception shape for existing callers. For example, NamespacesBase still checks for KeeperException.NotEmptyException as the cause to retry namespace deletion. Could we keep the ZK mapping unchanged in this PR, and handle both exception forms in markLedgerReplicated()? If we want to normalize ZK NOTEMPTY too, it may be safer to do that separately with updates to unwrap() and existing catch sites. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
