david-streamlio commented on PR #62: URL: https://github.com/apache/pulsar-connectors/pull/62#issuecomment-4929183651
@lhotari requesting your eyes on this one specifically — it's the least conventional of the integration tests in flight and touches shared build config, so an independent review seems warranted: 1. **Oracle container setup.** LogMiner needs archivelog mode, supplemental logging, and a privileged `c##dbzuser`, all done via a SYSDBA init script (`debezium-oracle-setup.sql`). Verified standalone (`LOG_MODE=ARCHIVELOG`, `SUPPLEMENTAL_LOG_DATA_MIN=YES`, no `ORA-`/`SP2-` errors), but it's the kind of setup that's easy to get subtly wrong. 2. **CI cost.** `gvenzl/oracle-free:23-slim-faststart` is ~1.6 GB and wants ~2 GB memory with a minutes-long startup. Worth a call on whether this belongs in the per-PR job or a separate/nightly one. 3. **A Testcontainers constraint worth knowing repo-wide:** `debezium-bom` pins Testcontainers core to 2.x, while the specialized modules (`oracle-free`, etc.) still target 1.21.x and reference shaded classes removed in 2.x — using `OracleContainer` fails with `NoClassDefFoundError`. This PR uses the `GenericContainer` pattern instead (as `DebeziumMysqlSourceTest` already does). Any future Debezium-module test will hit the same wall. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
