david-streamlio commented on PR #60: URL: https://github.com/apache/pulsar-connectors/pull/60#issuecomment-4929183787
@lhotari flagging this for your review because of the `task.id=0` line in the test config, which is a workaround for a real product bug rather than a test artifact — filed as #61. `AbstractKafkaConnectSource.open()` only calls `connector.taskConfigs()` when the adaptor's own `kafkaConnectorSourceClass` key is present. Debezium sources set Debezium's `connector.class`/`task.class` keys instead, so they all take the backward-compat branch and `taskConfigs()` never runs. Harmless for single-partition connectors (MySQL, Postgres — which is why existing tests pass), but SQL Server is multi-partition and needs the `task.id` that `taskConfigs()` would assign; without it a null reaches Debezium's JMX metrics layer and `open()` throws an NPE. Two things worth your judgement: whether the right fix in #61 is to have `DebeziumSource` populate `kafkaConnectorSourceClass`, or to invoke `taskConfigs()` in the backward-compat branch when a connector class is resolvable — and whether this test should land now with the workaround (the `task.id` line then gets deleted as part of #61, and this test becomes its regression guard) or wait for the fix. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
