david-streamlio commented on PR #81: URL: https://github.com/apache/pulsar-connectors/pull/81#issuecomment-4930486562
Good catch — the Kafka files were unintentional. The branch had been cut before #76 merged and carried its commit along; #14's rename of `FileListingThread` → `FileListingTask` then put it in conflict with master as well. Rebuilt the branch on current master. The diff is now exactly two files: ``` file/src/main/java/org/apache/pulsar/io/file/FileListingTask.java file/src/test/java/org/apache/pulsar/io/file/FileListingTaskBoundedQueueTest.java ``` The fix is ported to the renamed `FileListingTask`, and the regression test still earns its place: reverting `FileListingTask` to master's version makes `rejectedFilesAreRetriedOnceTheQueueDrains` fail with a `ConditionTimeoutException`, while `filesAreNotOfferedTwiceWhileTheyRemainOnDisk` passes either way — it pins the exactly-once property that the bug never broke. Full `:file:test` suite green. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
