namest504 commented on code in PR #24809: URL: https://github.com/apache/pulsar/pull/24809#discussion_r3555853345
########## pulsar-broker/src/test/java/org/apache/pulsar/client/impl/TableViewTest.java: ########## @@ -53,7 +53,6 @@ import org.apache.pulsar.client.api.PulsarClientException; import org.apache.pulsar.client.api.Reader; import org.apache.pulsar.client.api.Schema; -import org.apache.pulsar.client.api.TableView; Review Comment: Fixed. The import removal was caused by naming the impl class `TableView`, which shadowed the API interface in the same package. I went back to the `TableViewImpl` / `AbstractTableViewImpl` / `MessageMapperTableViewImpl` naming from your experiment branch, so the imports and the related diff churn are gone. The remaining changes in this file are the reflection target (`readAllExistingMessages` now lives in `AbstractTableViewImpl`) and the two new tests. ########## pulsar-client/src/main/java/org/apache/pulsar/client/impl/TableViewBuilderImpl.java: ########## @@ -22,14 +22,10 @@ import java.util.Map; import java.util.concurrent.CompletableFuture; import java.util.concurrent.TimeUnit; +import java.util.function.Function; import lombok.NonNull; import org.apache.commons.lang3.StringUtils; -import org.apache.pulsar.client.api.ConsumerCryptoFailureAction; -import org.apache.pulsar.client.api.CryptoKeyReader; -import org.apache.pulsar.client.api.PulsarClientException; -import org.apache.pulsar.client.api.Schema; -import org.apache.pulsar.client.api.TableView; Review Comment: Fixed, same root cause as above. The explicit import list is restored and the wildcard import is gone. ########## pulsar-client/src/test/java/org/apache/pulsar/client/impl/TableViewImplTest.java: ########## @@ -24,7 +24,6 @@ import static org.testng.Assert.assertNotNull; import org.apache.pulsar.client.api.CryptoKeyReader; import org.apache.pulsar.client.api.Schema; -import org.apache.pulsar.client.api.TableView; Review Comment: Fixed. This file now has no changes compared to master. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
