Copilot commented on code in PR #91:
URL: https://github.com/apache/pulsar-connectors/pull/91#discussion_r3560228320
##########
mqtt/src/integrationTest/java/org/apache/pulsar/io/mqtt/MqttSinkIntegrationTest.java:
##########
@@ -51,7 +53,11 @@ public class MqttSinkIntegrationTest {
private static final DockerImageName MOSQUITTO_IMAGE =
DockerImageName.parse("eclipse-mosquitto:2");
private final GenericContainer<?> mqttContainer = new
GenericContainer<>(MOSQUITTO_IMAGE)
- .withExposedPorts(MQTT_PORT);
+ .withExposedPorts(MQTT_PORT)
+ // Without an explicit wait strategy and startup timeout, a
stalled image pull hangs
+ // @BeforeClass with no bound, taking the whole CI job to its
45-minute limit.
Review Comment:
The inline comment claims a stalled image pull and container start can hang
`@BeforeClass` “with no bound”, but Testcontainers already has defaults (e.g.,
`pull.timeout` and a default wait strategy). Also, `withStartupTimeout(...)`
only configures the wait strategy timeout, not the image pull itself, so the
wording here is misleading.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
