david-streamlio commented on issue #94: URL: https://github.com/apache/pulsar-connectors/issues/94#issuecomment-4938964468
Fix opened as #100 — reorders `close()` to flush and hsync/ack while the stream is still open. Includes a regression test (`testCloseWithUnackedRecordsCommitsInsteadOfThrowing`) that fails with `ClosedChannelException` against the old order and passes with the fix. Leaving this issue open until #100 merges (it carries `Fixes #94`, so it will auto-close then). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
