sijie commented on a change in pull request #4955: [WIP][PIP-39] Introduce
system topic and topic policies service
URL: https://github.com/apache/pulsar/pull/4955#discussion_r325945526
##########
File path:
pulsar-broker/src/main/java/org/apache/pulsar/broker/service/persistent/PersistentTopic.java
##########
@@ -1031,7 +1042,7 @@ public void checkCompaction() {
.orElseThrow(() -> new KeeperException.NoNodeException());
- if (policies.compaction_threshold != 0
+ if (isSystemTopic || policies.compaction_threshold != 0
Review comment:
```suggestion
if (isSystemTopic() || policies.compaction_threshold != 0
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
